Remove Q_WS_* defines #42

Merged

MicheleC merged 2 commits from replace/q_ws_defines into master

MicheleC commented

Owner

As per title.

MicheleC added this to the R14.1.2 release milestone

MicheleC added 1 commit

0869619025

Remove Q_WS_* defines

Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>

MicheleC requested review from Core

MicheleC requested review from Owners

MicheleC changed title from ~~Replace Q_WS_* defines with TQ_WS_* equivalents~~ to Remove Q_WS_* defines

MicheleC referenced this pull request from TDE/tde

Merge tqtinterface into tqt3 (for R14.1.2) #145

MicheleC force-pushed replace/q_ws_defines from 0869619025 to bd0f2e4551

SlavekB requested changes

SlavekB left a comment

Owner

There is one note – a thing that would be appropriate to change.

qtinterface/tqt.h.cmake

SlavekB commented

Owner

This should be at least as a separate commit.

MicheleC commented

Poster

Owner

I thought about the same initially. Then since QT_NO_SQL is not used anywhere in TDE (it is already TQT_NO_SQL) I included here. If you like, I will make a separate commit for it.

SlavekB commented

Owner

Because commit log clearly says that the change is related to Q_WS_..., then this part is clearly contrary. Because it is just a small change, it may not be like a separate PR, but deserves to be as a separate commit.

MicheleC commented

Poster

Owner

Ok, PR updated.

MicheleC marked this conversation as resolved

MicheleC force-pushed replace/q_ws_defines from bd0f2e4551 to 14ad1125d0

SlavekB approved these changes

SlavekB left a comment

Owner

All looks good, thank you.

MicheleC merged commit 14ad1125d0 into master 2 months ago

MicheleC deleted branch replace/q_ws_defines

Reviewers

SlavekB approved these changes

TDE/Core was requested for review

The pull request has been merged as 14ad1125d0.

Sign in to join this conversation.

TDE/Core

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqtinterface#42