Align structure of translations/messages to similar modules. #2

Merged
MicheleC merged 1 commits from feat/translations/messages into master 3 years ago
Owner

As per discussion on tde-devs.

As per discussion on tde-devs.
MicheleC added 1 commit 3 years ago
5593085352
Align structure of translations/messages to similar modules.
MicheleC requested review from SlavekB 3 years ago
MicheleC added this to the R14.0.11 release milestone 3 years ago
SlavekB requested changes 3 years ago
SlavekB left a comment
Owner

This will not work as needed.

CMake project is named twin-style-decorator. If the subdirectory is not used in translations/messages, the translations will be installed as files twin-style-dekorator.po. But in the program is loaded catalog twin_dekorator – thus the twin_dekorator.po files. This is a completely different name than they are installed and therefore it cannot work.

To work, you need to either use the subfolder in translations/messages' – as it was (it was not intention), or load the twin-style-dekorator` catalog – the same as the CMake project name, as is translations installed when subfolder is not used (this is probably the way, which ones did you intend to).

This will not work as needed. CMake project is named `twin-style-decorator`. If the subdirectory is not used in `translations/messages`, the translations will be installed as files `twin-style-dekorator.po`. But in the program is loaded catalog `twin_dekorator` – thus the `twin_dekorator.po` files. This is a completely different name than they are installed and therefore it cannot work. To work, you need to either use the subfolder in `translations/messages' – as it was (it was not intention), or load the `twin-style-dekorator` catalog – the same as the CMake project name, as is translations installed when subfolder is not used (this is probably the way, which ones did you intend to).
MicheleC force-pushed feat/translations/messages from 5593085352 to 2c9db81ece 3 years ago
Poster
Owner

I don't have a deep knowledge of how catalogues are used, so thanks for checking and for the feedback. I have updated as required and also modified the names of the file for the desktop files translations. If my understanding of 'tde_create_translated_desktop' is correct, the last change was not strictly necessary, but I prefer to have consistent names when possible.

I don't have a deep knowledge of how catalogues are used, so thanks for checking and for the feedback. I have updated as required and also modified the names of the file for the desktop files translations. If my understanding of 'tde_create_translated_desktop' is correct, the last change was not strictly necessary, but I prefer to have consistent names when possible.
SlavekB reviewed 3 years ago
SlavekB left a comment
Owner

Good, now it will work. The only little thing remains: The catalog for messages is now generated as twin-style-decorator.pot while renaming the existing catalog has the target name tde-dekorator.pot. It deserves to adjust.

Good, now it will work. The only little thing remains: The catalog for messages is now generated as `twin-style-decorator.pot` while renaming the existing catalog has the target name `tde-dekorator.pot`. It deserves to adjust.
MicheleC force-pushed feat/translations/messages from 2c9db81ece to 8b834eeb66 3 years ago
Poster
Owner

oh yes, totally missed that, I should have spotted it myself.
Adjusted again.

oh yes, totally missed that, I should have spotted it myself. Adjusted again.
SlavekB approved these changes 3 years ago
SlavekB left a comment
Owner

Everything looks fine.

Everything looks fine.
MicheleC merged commit 8b834eeb66 into master 3 years ago
MicheleC deleted branch feat/translations/messages 3 years ago

Reviewers

SlavekB approved these changes 3 years ago
The pull request has been merged as 8b834eeb66.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/twin-style-dekorator#2
Loading…
There is no content yet.