Align structure of translations/messages to similar modules. #2
Merged
MicheleC
merged 1 commits from feat/translations/messages
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/translations/messages'
Deleting a branch is permanent. It CANNOT be undone. Continue?
As per discussion on tde-devs.
This will not work as needed.
CMake project is named
twin-style-decorator
. If the subdirectory is not used intranslations/messages
, the translations will be installed as filestwin-style-dekorator.po
. But in the program is loaded catalogtwin_dekorator
– thus thetwin_dekorator.po
files. This is a completely different name than they are installed and therefore it cannot work.To work, you need to either use the subfolder in
translations/messages' – as it was (it was not intention), or load the
twin-style-dekorator` catalog – the same as the CMake project name, as is translations installed when subfolder is not used (this is probably the way, which ones did you intend to).5593085352
to2c9db81ece
3 years agoI don't have a deep knowledge of how catalogues are used, so thanks for checking and for the feedback. I have updated as required and also modified the names of the file for the desktop files translations. If my understanding of 'tde_create_translated_desktop' is correct, the last change was not strictly necessary, but I prefer to have consistent names when possible.
Good, now it will work. The only little thing remains: The catalog for messages is now generated as
twin-style-decorator.pot
while renaming the existing catalog has the target nametde-dekorator.pot
. It deserves to adjust.2c9db81ece
to8b834eeb66
3 years agooh yes, totally missed that, I should have spotted it myself.
Adjusted again.
Everything looks fine.
8b834eeb66
into master 3 years agoReviewers
8b834eeb66
.