reduce scope of pointer variables #2

Затворени
opened преди 6 години by Ghost · 3 коментара
Ghost коментира преди 6 години

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:

[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.

[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.

I suggest 'item' to be moved in the "while (it2.current())" scope.

and

'skin' to be moved in the while "(it.current())" scope.

What do you think about?

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced: [skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced. [skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced. I suggest 'item' to be moved in the "while (it2.current())" scope. and 'skin' to be moved in the while "(it.current())" scope. What do you think about?
Притежател

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name :smile:
Притежател

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
MicheleC added this to the R14.0.6 release milestone преди 6 години
Притежател

Resolved by PR #3

Resolved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/yakuake/pulls/3
Впишете се за да се присъедините към разговора.
Няма етап
Няма изпълнители
2 участника
Известия
Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/yakuake#2
Зареждане…
Все още няма съдържание.