reduce scope of pointer variables #2

닫힘
opened 6 년 전 by Ghost · 3개의 코멘트
Ghost 코멘트됨, 6 년 전

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:

[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.

[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.

I suggest 'item' to be moved in the "while (it2.current())" scope.

and

'skin' to be moved in the while "(it.current())" scope.

What do you think about?

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced: [skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced. [skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced. I suggest 'item' to be moved in the "while (it2.current())" scope. and 'skin' to be moved in the while "(it.current())" scope. What do you think about?
MicheleC 코멘트됨, 6 년 전
소유자

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name :smile:
MicheleC 코멘트됨, 6 년 전
소유자

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
MicheleC R14.0.6 release 6 년 전 마일스톤을 추가하였습니다.
MicheleC 코멘트됨, 6 년 전
소유자

Resolved by PR #3

Resolved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/yakuake/pulls/3
MicheleC closed this issue 6 년 전
로그인하여 이 대화에 참여
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/yakuake#2
불러오는 중...
아직 콘텐츠가 없습니다.