reduce scope of pointer variables #2

Закрыто
открыт 6 лет назад пользователем Ghost · комментариев: 3
Ghost прокомментировал(а) 6 лет назад

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:

[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.

[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.

I suggest 'item' to be moved in the "while (it2.current())" scope.

and

'skin' to be moved in the while "(it.current())" scope.

What do you think about?

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced: [skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced. [skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced. I suggest 'item' to be moved in the "while (it2.current())" scope. and 'skin' to be moved in the while "(it.current())" scope. What do you think about?
MicheleC прокомментировал(а) 6 лет назад
Владелец

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name :smile:
MicheleC прокомментировал(а) 6 лет назад
Владелец

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
MicheleC добавил(а) к этапу R14.0.6 release 6 лет назад
MicheleC прокомментировал(а) 6 лет назад
Владелец

Resolved by PR #3

Resolved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/yakuake/pulls/3
MicheleC закрыл(а) эту задачу 6 лет назад
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет назначенных лиц
2 участников
Уведомления
Срок выполнения

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Reference: TDE/yakuake#2
Загрузка…
Пока нет содержимого.