Add section related to resolution of issue TDE/tdebase#1. #194

Hope I've done it correctly.

I have tested this and it seems to work.

Great, I will run a test here tomorrow and let you know.

Hope I've done it correctly.

Looks good at first sight. If I can suggest a small improvement, instead of "grep && sed+Log" you could use the same structure used in other cases "if grep -> sed + log" (see example just above your changes here ). Yes, Slavek and I can be a bit annoying sometimes with the changes we ask for 😅

the above just for code consistency

Well, at least I tried to be consistent... or else I would have used test instead of if ;-)
I'll make the proposed change right now.

Done

Hi Philippe,
I tested this together with TDE/tdelibs#129.
It works great if the user has the "text-x-generic-new" in his cache. It fails oherwise.
One of the users on my computer had a different icon there (not sure why but that is what it was) and the check failed to detect that.

Possible solutions:

we remove the complete cache line from the konq_history file. A bit intrusive, but I think the side effects are none and it is easy to implement. Would work regardless of what icon was there before
match exactly only the "/" entry in that file and discard whatever icon is there. Trickier to get it right compared to point 1.

What do you think?

Needs changes as per comments.

Thanks, this should do the job. I will rebuild and test!

Great, works fine even with that account that failed the previous test. If you can squash the commit, then I will merge.

Done, sorry for the delay

 # Remove Konqueror's icon cache entry for / (issue TDE/tdebase#1)
 if [ "$R14_VERSION" -lt "202103280" ]; then
   if [ "`grep "/,text-x-generic-new[,]*" ${TDEHOME}/share/config/konq_history`" ]; then
     sed -i "s:/,text-x-generic-new[,]*::g" ${TDEHOME}/share/config/konq_history

Add section related to resolution of issue TDE/tdebase#1. #194

Reviewers