Add includes to UI files to resolve FTBFS. #14
Merged
MicheleC
merged 1 commits from fix/includes
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/includes'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Sadly I just noticed by creating that PR Greg started initial work with his CMake conversion too in that area. But maybe he can rebase on my work? I hope that is okay. 😸
With that Amarok is building fine for me with CMake under Gentoo, without the CMake changes Greg is working on. But that should be not really related, I think.
Signed-off-by: Chris xchrisx@uber.space
Hi Chris, quick question. I don't have any build failure on amarok. Anyhow we experienced problems in the past on other packages and we needed similar fixes. Did you have a problem to build amarok without this patch?
Hello Michele, yes, the build failures were triggered in any case when using CMake for building, as I know. So with adding some Gentoo ebuild (which are in fact using CMake), that was triggered for Amarok too. Hope that helps. 😸
That said, you need to build with MP4V2 support so that the CMake conversion builds at the moment, if you want to test that. But that is not related to this PR here.
Looks good thanks!
a42dcb06ac
.