Add includes to UI files to resolve FTBFS. #14

Merged
MicheleC merged 1 commits from fix/includes into master 4 years ago
Chris commented 4 years ago
Collaborator

Sadly I just noticed by creating that PR Greg started initial work with his CMake conversion too in that area. But maybe he can rebase on my work? I hope that is okay. 😸

With that Amarok is building fine for me with CMake under Gentoo, without the CMake changes Greg is working on. But that should be not really related, I think.

Signed-off-by: Chris xchrisx@uber.space

Sadly I just noticed by creating that PR Greg started initial work with his CMake conversion too in that area. But maybe he can rebase on my work? I hope that is okay. :smile_cat: With that Amarok is building fine for me with CMake under Gentoo, without the CMake changes Greg is working on. But that should be not really related, I think. Signed-off-by: Chris <xchrisx@uber.space>
Owner

Hi Chris, quick question. I don't have any build failure on amarok. Anyhow we experienced problems in the past on other packages and we needed similar fixes. Did you have a problem to build amarok without this patch?

Hi Chris, quick question. I don't have any build failure on amarok. Anyhow we experienced problems in the past on other packages and we needed similar fixes. Did you have a problem to build amarok without this patch?
Chris commented 4 years ago
Poster
Collaborator

Hello Michele, yes, the build failures were triggered in any case when using CMake for building, as I know. So with adding some Gentoo ebuild (which are in fact using CMake), that was triggered for Amarok too. Hope that helps. 😸

That said, you need to build with MP4V2 support so that the CMake conversion builds at the moment, if you want to test that. But that is not related to this PR here.

Hello Michele, yes, the build failures were triggered in any case when using CMake for building, as I know. So with adding some Gentoo ebuild (which are in fact using CMake), that was triggered for Amarok too. Hope that helps. :smile_cat: That said, you need to build with *MP4V2* support so that the CMake conversion builds at the moment, if you want to test that. But that is not related to this PR here.
Chris closed this pull request 4 years ago
MicheleC closed this pull request 4 years ago
Owner

Looks good thanks!

Looks good thanks!
MicheleC deleted branch fix/includes 4 years ago
MicheleC added this to the R14.0.8 release milestone 4 years ago
The pull request has been merged as a42dcb06ac.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/amarok#14
Loading…
There is no content yet.