Added global shortcuts for switching to previous/next group #7

This resolves issue #6

8.1 KiB

Looks good.

One question is whether we should use the same shortcut across TDE for this, considering the discussion on TDE/tdebase#352.
Something like a common combination shared by kkbswitch/kxkb/TCC config page for switching keyboard layout forward and reverse.
What do you think?

Nice idea. KXkb already uses the shortcuts from the TCC module for next/previous layout, so we would need to make KKbSwitch respect these global shortcuts. But KKbSwitch also has some additional shortcuts of its own (Switch to layout n). They are dynamically created, so I doubt we could add them to the TCC module.

If we agree on this, then I won't merge this PR yet. I'll incorporate the changes into this PR.

I think we can have both. The dynamic switch to layout n keyboard shortcuts will be specific to kkbswitch, while the shortcuts for switching to previous/next group will use the global settings from TCC.

Umm, I've tried to implement that, but I discovered an important drawback to consider:

The shortcuts are stored in two different config files. It it simple to read from two config files and combine shortcuts. But it is not possible to choose where the TDEGlobalAccel object will write each shortcut, they all get written at once.

The option of having two separate TDEGlobalAccel objects is also not viable, as the KKeyChooser class only works on a single TDEAccel/TDEGlobalAccel object, and having two KKeyChooser widgets might be needlessly complex.

What do you think?

In such case, I think we can treat kkbswitch as an independent application with its own keyboard shortcuts written to its own file (pretty much as it is now) so we can simply merge this PR as is.

Merged + backported for R14.1.1.

Thanks for the good work!

Added global shortcuts for switching to previous/next group #7

Reviewers