Drop TQT_BASE_OBJECT* defines #9
Merged
MicheleC
merged 1 commits from drop/tqt-base-object-defines into master 9 months ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'drop/tqt-base-object-defines'
Deleting a branch is permanent. It CANNOT be undone. Continue?
TQT_BASE_OBJECT* defines will later be removed from tqtinterface.
a52650dabatoe524a45ee79 months agoI did not investigate it in more detail, but there is a difference from what the code looked like originally.
KDE_NO_EXPORT void KMPlayerApp::fullScreen () {// if (TQT_TQOBJECT(const_cast<TQT_BASE_OBJECT_NAME*>(sender ()))->metaObject ()->inherits ("TDEAction"))if (TQT_TQOBJECT(const_cast<TQT_BASE_OBJECT_NAME*>(sender ()))->inherits ("TDEAction"))if (sender()->inherits("TDEAction"))The original code also contained
metaObject(). Is that essential?That line was commented out long ago. TQObject contains the required
inherits, so it should not be an issue. I did a build test and did not see any FTBFS in trixie.The line in the comment was precisely when the
QObject=>TQT_BASE_OBJECT_NAMEwas changed – that's why I have this question. See commit769e63d24a.https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/src/branch/master/src/kernel/qobject.cpp#L865
TQObject::inherits()uses metaobject() internally already, so I don't see a problem with the current version of code.Yes, great, that's a clear explanation of why it's okay.
It looks good.
e524a45ee7into master 9 months agoReviewers
e524a45ee7.