#2 conversion to cmake

Merged
SlavekB merged 2 commits from feat/cmakeConv into master 5 months ago
cethyel commented 5 months ago

I’ve added a man page taken from your Debian repo.

I’ve changed the name KDE into TDE in folder ../HTML/index.html.

I’ve changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

I've added a man page taken from your Debian repo. I've changed the name KDE into TDE in folder ../HTML/index.html. I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.
SlavekB commented 5 months ago
Owner

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15.

During that, I noticed a code that seems to me wrong. look at krename/krenameimpl.cpp#L1174 - I believe that there is an endless loop, because d is initiated as '/' and the other parts are added during loop => can never be met !d->isEmpty().

Am I wrong, or am I right?

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15. During that, I noticed a code that seems to me wrong. look at [krename/krenameimpl.cpp#L1174](src/branch/master/krename/krenameimpl.cpp#L1174) - I believe that there is an endless loop, because `d` is initiated as `'/'` and the other parts are added during loop => can never be met `!d->isEmpty()`. Am I wrong, or am I right?
SlavekB deleted branch feat/cmakeConv 5 months ago
SlavekB added this to the R14.0.6 release milestone 5 months ago
SlavekB commented 5 months ago
Owner

The endless loop will be solved in a separate commit.

The endless loop will be solved in a separate commit.
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.