TDE
/
krename
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

conversion to cmake #2

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 6 years ago
Conversation 2 Commits 1 Files Changed 14
Ghost commented 6 years ago

I've added a man page taken from your Debian repo.

I've changed the name KDE into TDE in folder ../HTML/index.html.

I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

I've added a man page taken from your Debian repo. I've changed the name KDE into TDE in folder ../HTML/index.html. I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.
SlavekB commented 6 years ago
Owner

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15.

During that, I noticed a code that seems to me wrong. look at krename/krenameimpl.cpp#L1174 - I believe that there is an endless loop, because d is initiated as '/' and the other parts are added during loop => can never be met !d->isEmpty().

Am I wrong, or am I right?

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15. During that, I noticed a code that seems to me wrong. look at [krename/krenameimpl.cpp#L1174](src/branch/master/krename/krenameimpl.cpp#L1174) - I believe that there is an endless loop, because `d` is initiated as `'/'` and the other parts are added during loop => can never be met `!d->isEmpty()`. Am I wrong, or am I right?
SlavekB closed this pull request 6 years ago
SlavekB deleted branch feat/cmakeConv 6 years ago
SlavekB added this to the R14.0.6 release milestone 6 years ago
SlavekB commented 6 years ago
Owner

The endless loop will be solved in a separate commit.

The endless loop will be solved in a separate commit.
The pull request has been merged as e023691c15.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/krename#2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes