TDE
/
krename
6
0
Fork 0
Código Incidencias Pull Requests Lanzamientos Wiki Actividad
Etiquetas Hitos

conversion to cmake #2

Fusionado
SlavekB fusionados 1 commits de feat/cmakeConv en master hace 6 años
Conversación 2 Commits 1 Archivos modificados 14
Ghost comentado hace 6 años

I've added a man page taken from your Debian repo.

I've changed the name KDE into TDE in folder ../HTML/index.html.

I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

I've added a man page taken from your Debian repo. I've changed the name KDE into TDE in folder ../HTML/index.html. I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.
SlavekB comentado hace 6 años
Propietario

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15.

During that, I noticed a code that seems to me wrong. look at krename/krenameimpl.cpp#L1174 - I believe that there is an endless loop, because d is initiated as '/' and the other parts are added during loop => can never be met !d->isEmpty().

Am I wrong, or am I right?

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15. During that, I noticed a code that seems to me wrong. look at [krename/krenameimpl.cpp#L1174](src/branch/master/krename/krenameimpl.cpp#L1174) - I believe that there is an endless loop, because `d` is initiated as `'/'` and the other parts are added during loop => can never be met `!d->isEmpty()`. Am I wrong, or am I right?
SlavekB cerró este pull request hace 6 años
SlavekB rama eliminada feat/cmakeConv hace 6 años
SlavekB ha añadido esto al hito R14.0.6 release hace 6 años
SlavekB comentado hace 6 años
Propietario

The endless loop will be solved in a separate commit.

The endless loop will be solved in a separate commit.
El Pull Request se ha fusionado como e023691c15.
Inicie sesión para unirse a esta conversación.
Revisores
Solicitar revisión
No hay revisores
Etiquetas
Aplicar etiquetas
Limpiar etiquetas
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Sin etiquetas GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Fijar hito
Limpiar Milestone
No hay elementos
Sin Milestone
R14.0.6 release
Asignados
Asignar usuarios
Limpiar asignados
No asignados
2 participantes
Notificaciones
Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: TDE/krename#2
Escribir Vista previa
Cargando…
Cancelar
Guardar
Aún no existe contenido.
Eliminar la rama con el nombre 'feat/cmakeConv'

Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?

No
Sí