Fix to detect gnokii header file #57
Merged
SlavekB
merged 1 commits from feat/fix-gnokii-detection into master 3 years ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/fix-gnokii-detection'
Deleting a branch is permanent. It CANNOT be undone. Continue?
It is used as the build condition in kaddressbook.
partially resolve #56
It looks good, just there is one small note.
if( WITH_GNOKII AND (BUILD_KADDRESSBOOK OR BUILD_KMOBILE) )check_include_file( "gnokii.h" HAVE_GNOKII_H )It seems like a good idea to do first test the presence of gnokii and only then test the presence of the header. It could also be useful for the fact that the gnokii module test can set
GNOKII_INCLUDEDIR, or something like that.It is the reason why "partially resolve #56".
5d8b6e40c4to0ed55e9b493 years ago0ed55e9b49toddad09c0643 years agoGreat, it looks good. You may consider a small simplification – see the comment.
if( NOT GNOKII_FOUND )tde_message_fatal( "gnokii are requested, but was not found on your system" )else( )tde_save( CMAKE_REQUIRED_INCLUDES )I suggest a small simplification: instead of a separate
tde_save(...)followed byset(...), it is possible to use thetde_save_and_set(...)macro.ddad09c064to9354d05e273 years ago9354d05e27todea6d6ca6a3 years agoGreat, thank you, it looks good.
dea6d6ca6ainto master 3 years agoReviewers
dea6d6ca6a.