asturm
0 Followers · 0 Following
  • Joined on
Repositories Packages Public Activity Starred Repositories

asturm commented on pull request TDE/tde-packaging-gentoo#191

media-libs/lcms: Remove unbuildable package due to py27 dep

No need to, I can change it. I just hope there is some effort upstream to port those applications away from lcms1.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#191

media-libs/lcms: Remove unbuildable package due to py27 dep

That's a possibility, but neither package is available in the overlay. trinity-base/ksvg is the only revdep as far as I can see.

3 years ago

asturm created pull request TDE/tde-packaging-gentoo#191

media-libs/lcms: Remove unbuildable package due to py27 dep

3 years ago

asturm pushed to feat/lcms-0-cleanup at TDE/tde-packaging-gentoo

  • 6ac0550e24 media-libs/lcms: Remove unbuildable package due to py27 dependency
  • efa4a4d53d trinity-base/ksvg: Drop 14.0.8 (r0)
  • 1e489e3bb0 trinity-base/ksvg: Switch to media-libs/lcms:2

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

It's not a sentence so we generally don't use full stop in `DESCRIPTION`.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Style: For all ebuilds: Dependencies should always be sorted alphanumerically, with all unconditional deps before the use-conditional ones.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

No need for `\` within any quotations.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Could you test that though? In that case it should depend on tdelibs[ssl=].

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Cleanup trailing space

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

`nvidia-settings` was really merged into `nvidia-drivers`, and it is available via `x11-drivers/nvidia-drivers[tools]` according to `equery u nvidia-drivers`.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Superfluous `COMMON_DEPEND`, as below we can see `DEPEND=${RDEPEND}` anyway.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

all eclass meta vars should always be defined before `inherit`.

3 years ago

asturm suggested changes for TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

- MR re-introduces superfluous `14.0.7` manifests. This is easily fixed by running `repoman manifest` inside `trinity-apps` directory. You can simply `git commit --amend` afterwards. You can also use this to change the commit message of current HEAD when needed.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Style: For all ebuilds: There should always be an empty line after `EAPI`.

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Style: For all ebuilds:

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

For all ebuilds: Should be `local mycmakeargs`

3 years ago

asturm commented on pull request TDE/tde-packaging-gentoo#189

features/trinity-applications-stable-second-attempt

Style: For all ebuilds: During my time submitting PRs to kde overlay I was always told to get rid of filler words at the beginning of `DESCRIPTION`. That's just a nitpick, but when you think about it, really nothing is gained if every description starts with `A/An` etc.

3 years ago

asturm pushed to feat/much-less-eclass-magic at TDE/tde-packaging-gentoo

3 years ago

asturm pushed to feat/much-less-eclass-magic at TDE/tde-packaging-gentoo

  • 5a0bd4efd5 trinity-base/kmtrace: Cleanup TrailingEmptyLine
  • 0be4e45e20 trinity-base/kdesktop: Drop too short longdescription from metadata
  • 88802a005c profiles: desc: Add l10n.desc with missing L10N USE_EXPAND descriptions
  • 73fe0c1fca dev-tqt/tqt: Add release/live switch, sort DEPENDs
  • 77ddd1eb61 */*: 9999: Sanitise eclass/ebuild vars, drop set-trinityver and need-trinity
  • Compare 11 commits »

3 years ago